choose supernode selection strategy at run-time #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #864 +/- ##
==========================================
- Coverage 18.37% 18.31% -0.07%
==========================================
Files 41 41
Lines 8513 8547 +34
==========================================
+ Hits 1564 1565 +1
- Misses 6949 6982 +33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--select-rttparameter to the edge allowing for supernode selection strategy configuration at run-time. No more need for compile-time macro definition.Documentation has been adapted accordingly.
Also, this lays ground for the addition of further selection strategies, e.g. based on supernode MAC, see #857 / #860.